RS/JX/Rule16-6 #1344
Merged
RS/JX/Rule16-6 #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiarongx-Xie
requested review from
jugonzal07,
weilixu,
yunjoonjung-PNNL and
JacksonJ-KC
…-checking-tool into RS/JX/Rule16-6
yunjoonjung-PNNL
approved these changes
May 29, 2024
|
|
||
| def is_applicable(self, context, data=None): | ||
| rmd_p = context.PROPOSED | ||
| return find_all("$.ruleset_model_descriptions[0].buildings[*].elevators", rmd_p) |
There was a problem hiding this comment.
Can you add [*] at the end of the json path?
weilixu
reviewed
May 31, 2024
| from rct229.schema.config import ureg | ||
| from rct229.rule_engine.rule_base import RuleDefinitionBase | ||
| from rct229.rule_engine.rule_list_indexed_base import RuleDefinitionListIndexedBase | ||
| from rct229.rule_engine.ruleset_model_factory import produce_ruleset_model_instance |
There was a problem hiding this comment.
import error.
produce_ruleset_model_description
| from rct229.rule_engine.rule_base import RuleDefinitionBase | ||
| from rct229.rule_engine.rule_list_indexed_base import RuleDefinitionListIndexedBase | ||
| from rct229.rule_engine.ruleset_model_factory import produce_ruleset_model_instance | ||
| from rct229.rulesets.ashrae9012019 import BASELINE_0, PROPOSED |
There was a problem hiding this comment.
No need to import PROPOSED
| class ElevatorRule(RuleDefinitionBase): | ||
| def __init__(self): | ||
| super(Section16Rule6.ElevatorRule, self).__init__( | ||
| rmds_used=produce_ruleset_model_instance( |
|
|
||
| def is_applicable(self, context, data=None): | ||
| rmd_p = context.PROPOSED | ||
| return find_all( |
There was a problem hiding this comment.
Could you follow this comment and fix this is applicable logic?
…-checking-tool into RS/JX/Rule16-6
# Conflicts: # rct229/rulesets/ashrae9012019/section16/__init__.py
… into RS/JX/Rule16-6 # Conflicts: # docs/section16/Rule16-6.md # rct229/rulesets/ashrae9012019/section16/__init__.py
|
@Jiarongx-Xie I added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule has been tested.