Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS/YJ/Rule 16-1 #1346

Merged
merged 33 commits into from
Jun 21, 2024
Merged

RS/YJ/Rule 16-1 #1346

merged 33 commits into from
Jun 21, 2024

Commits on May 6, 2024

  1. Merge branch 'RS/YJ/Rule_16-2' of https://github.com/pnnl/ruleset-che… 

    …cking-tool into RS/YJ/Rule_16-1
    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7f543ca View commit details
    Browse the repository at this point in the history

  2. Finished dev 16-1

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5a3bcd2 View commit details
    Browse the repository at this point in the history

  3. Fixed elevator_mechanical_efficiency_b

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bf1e78b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Addressed PR comments

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 8, 2024
    Configuration menu
    Copy the full SHA
    bc54e0f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. First cut at 16-1

    gonz102 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    641b064 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'RT/JG/ruletest_16_1' of https://github.com/pnnl/ruleset… 

    …-checking-tool into RS/YJ/Rule_16-1
    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 14, 2024
    Configuration menu
    Copy the full SHA
    30197d9 View commit details
    Browse the repository at this point in the history

  2. Fixed wrong part

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b5275f5 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Updated unneeded import

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a1eded8 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Isort

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5bffe19 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'RS/YJ/Rule_16-2' of https://github.com/pnnl/ruleset-che… 

    …cking-tool into RS/YJ/Rule_16-1
    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d7c0615 View commit details
    Browse the repository at this point in the history

  2. Replaced rmi with rmd

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 28, 2024
    Configuration menu
    Copy the full SHA
    ef966ee View commit details
    Browse the repository at this point in the history

  3. Fixed table G3 9 3 fins file

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4b306e8 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Added not applicable case when there is no or empty elevator in baseline

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4e833ee View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fixed is applicable logic

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    cc20bef View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Updated the not applicable logic from Jiarong

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5a10c86 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'develop' of https://github.com/pnnl/ruleset-checking-tool… 

    … into RS/YJ/Rule_16-1
    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8daee1f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Updated 16-1 ruletest to include not applicable ruletest

    gonz102 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    47c7a68 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'RS/YJ/Rule_16-1' of https://github.com/pnnl/ruleset-che… 

    …cking-tool into RT/JG/ruletest_16_1
    gonz102 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b3e1baa View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'develop' of https://github.com/pnnl/ruleset-checking-tool… 

    … into RS/YJ/Rule_16-1
    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c54e70a View commit details
    Browse the repository at this point in the history

  2. Updated motor_brake_horsepower_b unit conversion

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    424a652 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Addressed WX PR comments

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2e82d35 View commit details
    Browse the repository at this point in the history

  2. Updated to use ashrae_90_1_table_G3_9_1.json table

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bd6db4e View commit details
    Browse the repository at this point in the history

  3. Added typehint for table_G3_9_1_lookup func

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3f85c91 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. update error key name

    @weilixu
    weilixu committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9506c40 View commit details
    Browse the repository at this point in the history

  2. fix the logic in the data function

    @weilixu
    weilixu committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    96519ec View commit details
    Browse the repository at this point in the history

  3. Corrected the wrong parts in the rule and ruletest

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a50be39 View commit details
    Browse the repository at this point in the history

  4. delete 746 since it's a conversion factor hp-W

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    951ade6 View commit details
    Browse the repository at this point in the history

  5. update types

    @weilixu
    weilixu committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    15edff0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'RS/YJ/Rule_16-1' of https://github.com/pnnl/ruleset-che… 

    …cking-tool into RS/YJ/Rule_16-1
    @weilixu
    weilixu committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5691d3d View commit details
    Browse the repository at this point in the history

  7. Corrected ruletest JSON values.

    gonz102 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e44561a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'RS/YJ/Rule_16-1' of https://github.com/pnnl/ruleset-che… 

    …cking-tool into RS/YJ/Rule_16-1
    gonz102 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6517906 View commit details
    Browse the repository at this point in the history

  9. black formatting

    @yunjoonjung-PNNL
    yunjoonjung-PNNL committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d464e50 View commit details
    Browse the repository at this point in the history

  10. update

    @weilixu
    weilixu committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    78cfe95 View commit details
    Browse the repository at this point in the history