RDS/JDJ/Rule 12-2 #1347
Merged
RDS/JDJ/Rule 12-2 #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonJ-KC
requested review from
JasonGlazer,
supriyagoel,
weilixu,
claperle and
KarenWGard
claperle
reviewed
May 10, 2024
claperle
reviewed
May 10, 2024
claperle
reviewed
May 10, 2024
claperle
reviewed
May 10, 2024
claperle
reviewed
Jul 1, 2024
claperle
reviewed
Jul 1, 2024
claperle
approved these changes
Jul 1, 2024
claperle
reviewed
Jul 1, 2024
KarenWGard
reviewed
Jul 3, 2024
docs/section12/Rule12-2.md
Outdated
| **Rule Assertion:** | ||
| Case 1: The baseline and proposed miscelleaneous equipment schedules match for all hours: PASS `if comparison_data['total_hours_matched'] == len(misc_equip_schedule_b == len(misc_equip_schedule_p): PASS` | ||
| Case 2: The proposed automatic receptacle control was not specified: UNDETERMINED `elif auto_receptacle_control_p == Null: UNDETERMINED` | ||
| Case 3: The baseline and proposed miscelleaneous equipment both have automatic controls, but schedules have unequal equivalent full load hours: FAIL and raise message `elif auto_receptacle_control_p and auto_receptacle_control_b and comparison_data["eflh_difference"] != 0: FAIL and raise_message = "The baseline miscellaneous equipment schedule has automatic receptacle controls indicating that there is an applicable requirement for automatic controls for the space in Section 8.4.2. Miscellaneous equipment schedules may only differ when the proposed design has automatic receptacle controls and there are no applicable requirements in Section 8.4.2 for the space."` |
There was a problem hiding this comment.
what if the proposed is greater than the baseline? IE, it has worse controls
There was a problem hiding this comment.
Good catch, I reorded the cases to make sure that this FAIL case you mentioned is caught (in what is now case 6) before the UNDETERMINED case (now case 7)
claperle
approved these changes
Jul 3, 2024
KarenWGard
approved these changes
Jul 10, 2024
… into RDS/JDJ/12-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.