Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDS/JDJ/Rule 12-1 #1348
RDS/JDJ/Rule 12-1 #1348
Changes from 5 commits
82b2dce
4fa18b9
dd35d8e
74f798d
dd24c52
02945b6
2b04a80
8115a7e
712947b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is Rule 1-7 will check and highlight these outcome so this rule essentially, provides more detail messages about the failures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MiscellaneousEquipment.power is set to FALSE for the AppG B_RMD Equals P_RMD column in the extra schema so 1-6 will not check this (1-7 is for proposed vs. user). False is appropriate for 1-6 and we check in this rule instead because when the project is for a beyond-code program the proposed is allowed to be less than the baseline, but we are unable to tell if the reduction was correctly applied for the beyond code program so outcome is UNDETERMINED.
If proposed is greater than the baseline, FAIL. Also, as Christina pointed out,
if RPD.compliance_path == CODE_COMPLIANT
, any difference between proposed and baseline is a FAIL.