Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Test 16-1 #1357

Merged
merged 18 commits into from
Jun 21, 2024
Merged

Rule Test 16-1 #1357

merged 18 commits into from
Jun 21, 2024

Conversation

jugonzal07
Copy link
Contributor

First cut at rule test 16-1

@yunjoonjung-PNNL
Copy link
Collaborator

Juan,

We need proposed for all the cases because of the not applicable check. Can you add it to the RPD?

@yunjoonjung-PNNL
Copy link
Collaborator

Can you add the number_of_floors_served key in case (a)?

@weilixu
Copy link
Collaborator

weilixu commented Jun 11, 2024

Need revisit @jugonzal07 , this test json is not completed.

@yunjoonjung-PNNL
Copy link
Collaborator

Juan,

For case (c), could you check if the motor_power in baseline should be 46508.553 W (=62.369 hp)? Other than this case, all cases passed.

@weilixu weilixu merged commit c54e70a into develop Jun 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants