Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rds/kjw/function get swh uses associated with each building segment #1401

Conversation

KarenWGard
Copy link
Collaborator

No description provided.

@@ -0,0 +1,28 @@
## get_SWH_uses_associated_with_each_building_segment

Description: This function gets all the SWH uses connected to a building segment. This function is primarily to encapsulate getting service water heating uses in one function so that if a change is made in the schema as to how service water heating use is specified, the RCT only needs to change in one place.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so you are saying you would just have to update this function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

- **swh_uses**: A list containing the ids of all service water heating uses associated with a building segment

Function Call:
- get_component_by_ID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different from get_obj_by_id?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no... I'm not sure which is correct, but my understanding is that the RCT team understood either way what's going on

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure they would understand. I think I am just advocating for cleanliness more now because I am also currently going through every single TCD description and making revisions to have consistent wording and formatting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistency is definitely better when possible!

@yunjoonjung-PNNL
Copy link
Collaborator

The service_water_heating_uses key should be under the spaces level not the building_segments level.

@KarenWGard
Copy link
Collaborator Author

The service_water_heating_uses key should be under the spaces level not the building_segments level.

We are proposing changes to the schema regarding the location of service_water_heating_uses - I had hoped that they would be approved by now and this function is written in accordance with those changes.

@yunjoonjung-PNNL
Copy link
Collaborator

The service_water_heating_uses key should be under the spaces level not the building_segments level.

We are proposing changes to the schema regarding the location of service_water_heating_uses - I had hoped that they would be approved by now and this function is written in accordance with those changes.

I see! Thank you for letting me know about this. I implemented this function with the service_water_heating_usees under the space to make the function work. We can update it once the schema addresses this part.

… into RDS/KJW/function_get_SWH_uses_associated_with_each_building_segment
@weilixu weilixu merged commit 13ab9eb into develop Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants