-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCT/YJ/get_HVAC_systems_primarily_serving_comp_rooms #1408
RCT/YJ/get_HVAC_systems_primarily_serving_comp_rooms #1408
Conversation
...29/rulesets/ashrae9012019/ruleset_functions/get_HVAC_systems_primarily_serving_comp_rooms.py
Show resolved
Hide resolved
hvac_systems_primarily_serving_comp_rooms_list = [] | ||
for hvac_id in find_all( | ||
"$.buildings[*].building_segments[*].heating_ventilating_air_conditioning_systems[*].id", | ||
rmd, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use for hvac_id in hvac_zone_list_w_area_dict
?
...lesets/ashrae9012019/ruleset_functions/get_HVAC_systems_primarily_serving_comp_rooms_test.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yun Joon for the dev, I left a few comments.
I thought this is a modification, not developing a new function? |
Good point! I wasn't aware that this function already exists. I'll close this PR and make updates on the existing function in a new PR. |
No description provided.