RS/JX/Rule12-2 #1424
Merged
RS/JX/Rule12-2 #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilixu
reviewed
Jul 30, 2024
… into RS/JX/Rule12-2
…-checking-tool into RS/JX/Rule12-2
… into RS/JX/Rule12-2
… into RS/JX/Rule12-2
… into RS/JX/Rule12-2
…h that the EFLH in the baseline case < proposed case
…-checking-tool into RS/JX/Rule12-2
|
@jugonzal07 @Jiarongx-Xie Please let me know if this rule is ready for review. |
It's almost there. We still need to double-check test case d. Will keep you posted. |
…t-error RS/JDJ/get surface conditioning category dict error
…ntrols to correctly trigger the undetermined case.
…-checking-tool into RS/JX/Rule12-2
|
Thank you for the review @weilixu. I have addressed all the comments, and all test cases have successfully passed in local testing. |
… into RS/JX/Rule12-2
…hecking-tool into RS/JX/Rule12-2 # Conflicts: # rct229/rulesets/ashrae9012019/section12/__init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule has been tested.