Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCT/YJ/get_swh_uses_associated_with_each_building_segment #1500

Conversation

yunjoonjung-PNNL
Copy link
Collaborator

No description provided.

… into RCT/YJ/get_swh_uses_associated_with_each_building_segment
Returns
-------
swh_uses: list
A list containing the ids of all service water heating uses associated with a building segment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add additional to include extreme case or an empty list if no service water heating uses are found in the building segment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@weilixu
Copy link
Collaborator

weilixu commented Aug 19, 2024

Approved with one minor update request.
Good work, thank you Yun Joon.

Copy link
Collaborator

@Jiarongx-Xie Jiarongx-Xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you Yun Joon!

@yunjoonjung-PNNL yunjoonjung-PNNL merged commit ac0791d into develop Aug 20, 2024
2 checks passed
@yunjoonjung-PNNL yunjoonjung-PNNL deleted the RCT/YJ/get_swh_uses_associated_with_each_building_segment branch September 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants