update 5_2 #1518
Merged
update 5_2 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonJ-KC
reviewed
Sep 4, 2024
| @@ -51,7 +51,7 @@ def get_calc_vals(self, context, data=None): | |||
| "baseline_surfaces_casting_shade_ids": baseline_surfaces_casting_shade_ids | |||
| } | |||
|
|
|||
| def applicability_check(self, context, calc_vals, data): | |||
| def rule_check(self, context, calc_vals=None, data=None): | |||
| # if there are surfaces casting shade, set to undetermined | |||
| # if there are no surfaces casting shade, set to not applicable. | |||
| return not len(calc_vals["baseline_surfaces_casting_shade_ids"]) == 0 | |||
There was a problem hiding this comment.
rule should pass when length is 0
JacksonJ-KC
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 5-2 to full evaluation rule