RS/YJ/Rule 11-12

[yunjoonjung-PNNL]

This rule hasn't been tested and not ready for review yet.

[yunjoonjung-PNNL]

For this part, please see the email between Juan and me (Sep 19th - title: RCT, Question about ServiceWaterHeatingUse-USE unit). Please let me know if you think differently.

[weilixu]

I don't think we need to care about the unit for now.
Checking the requirement of rule, it says check to see if the use has SWH loads
This implies we need to verify if the use actually has load - so your implementation here is good.
Perhaps you don't need to use getattr_. We can assume missing data is 0 load.

[weilixu]

I think the rule needs to be updated.

[weilixu]

you can make a create_data function and add data:

return {
    "is_leap_year_b": find_one("$.calendar.is_leap_year", rmd_b),
    "schedules_b": find_all("$.schedules[*], rmd_b),
    "schedules_p": find_all("$.schedules[*], rmd_p)
}

[weilixu]

Following the above create_data suggestion, you can use find_exactly_one_with_field_value("$.schedules_b[*]", "id", bldg_open_sch_id_b, data) to get the bldg_open_sch_b.

[weilixu]

is_leap_year_b is not in the data with the current implementation.

[weilixu]

Need to add a is_applicable here to check the logic check that there is SWH in the proposed model AND that the building has a 24hr operating schedule

In RDS logic section, it is also said: A building must both have SWH loads and a 24hr operating schedule for this rule to be applicable. So it is appropriate to add is_applicable check under building level.

[weilixu]

I am not sure what is this filtering.
If the intention is just to make sure the building has 24 hours operation, then we should put this logic to is applicable because list_filter is a silence pass - no outcome returned.

[weilixu]

I will move this logic to RMD level. for example, creating a

swh_uses_associated_with_each_building_segment_p: 
{
    building_segment_id: get_swh_uses_associated_with_each_building_segment(
                            rmd_p, building_segment_p["id"]
                        )
    for building_segment_id in find_all("$.buildings[*].building_segments[*].id, rmd_p
}

I can skip this create data here.

[weilixu]

I don't think the rule shall be evaluated at service water use level. Instead, I think it should be at the Building level.
if you read the applicable message, it starts with the building not the water use.

Also, if we check the logic - a great amount of logic is to verify whether the building has SWH load and it is operate 24 hours.

[weilixu]

I don't think we need to care about the unit for now.
Checking the requirement of rule, it says check to see if the use has SWH loads
This implies we need to verify if the use actually has load - so your implementation here is good.
Perhaps you don't need to use getattr_. We can assume missing data is 0 load.