Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS/JX/Rule11-11 #1525

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

RS/JX/Rule11-11 #1525

wants to merge 9 commits into from

Conversation

Jiarongx-Xie
Copy link
Collaborator

@Jiarongx-Xie Jiarongx-Xie commented Sep 16, 2024 •
edited
Loading

This rule has been tested and is ready for review.

@Jiarongx-Xie Jiarongx-Xie changed the base branch from master to develop September 16, 2024 19:52
@Jiarongx-Xie Jiarongx-Xie self-assigned this Sep 16, 2024
@Jiarongx-Xie Jiarongx-Xie marked this pull request as draft September 16, 2024 19:52
@Jiarongx-Xie Jiarongx-Xie marked this pull request as ready for review October 1, 2024 16:09
weilixu
weilixu reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@weilixu weilixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think RDS logics can be simplified in the actual implementation - I provided the suggestions.
Also, I recommend use swh_use loads instead of flag in the calc_vals for reporting purpose.

rct229/rulesets/ashrae9012019/section11/section11rule11.py Outdated Show resolved Hide resolved
rct229/rulesets/ashrae9012019/section11/section11rule11.py Outdated Show resolved Hide resolved
@Jiarongx-Xie
Copy link
Collaborator Author

I think RDS logics can be simplified in the actual implementation - I provided the suggestions. Also, I recommend use swh_use loads instead of flag in the calc_vals for reporting purpose.

The implementation you suggested is much more elegant. I have revised the script accordingly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjoonjung-PNNL yunjoonjung-PNNL Awaiting requested review from yunjoonjung-PNNL

@weilixu weilixu Awaiting requested review from weilixu

At least 2 approving reviews are required to merge this pull request.

Assignees

@Jiarongx-Xie Jiarongx-Xie

Labels
ReadytoMerge rule_definition section11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiarongx-Xie @weilixu