-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added column sample generic-published-version #850
base: master
Are you sure you want to change the base?
Conversation
Hi @mkacena . Thank you for sharing this awesome sample! I didn’t know it was possible to open a specific version of a file this way—very cool! After trying it out, I had one point of concern regarding the "Download" button. I thought clicking the button would download the file, but when I clicked it, it did not download, but opened the specified version of the file. Therefore, I felt a little uncomfortable with the button labeled "Download"... If you agree with this, how about replacing the label “Download” with some other letter? (e.g. Open Version XX.0) |
Hi @tecchan1107 . Thank you for your feedback. Can I ask how did you manage to get the file open? This was actually my main concern - that it downloads files instead of opening them in browser or app. I have tried it in 2 different tenants with libraries of different settings, and different browsers (Firefox, Chrome), but it always downloaded the file. I would be actually happy if I could make it open the previous version instead of download. |
I did not set anything in particular, but the file opened... When I click the download button in my environment, I get the following behavior (sorry for the Japanese) However, when I clicked on the Visio download button, the Visio file was downloaded. In my environment, I have desktop apps like Word, PowerPoint, and Excel installed, but the Visio desktop app is not installed. Maybe the file is opened or downloaded depending on whether the target desktop app is installed or not...? |
I see. Thank you, that was really helpful. You use Microsoft Edge and it behaves differently from Firefox and Chrome. It asks whether to open file, and is able to open Word app directly with file stored in SharePoint. I tried to make Firefox do the same and after adjusting settings for handling files, it now asks whether to open or save file. So I can open it "directly", but in fact the file is being downloaded and stored locally in Downloads folder. Chrome was the "worst" in this case. I have spent hours trying to make it open Word files directly, but there is not even a setting as in Firefox, and the official Office extension does not work. @tecchan1107 Anyway, do you still want me to update the sample as you suggested (rename to "Open Version XX.0")? Just a real-world experience: I had the button named "Open" at one customer, but users were using Chrome and the files were being downloaded so they complained about the name being misleading. |
Hi @mkacena !
Yes. I usually use Microsoft Edge and was using Microsoft Edge when the above video was taken.
I also tried a different browser and the file downloaded!
Hmmm, do you have any other suggestions...? I've been thinking for the past few days about what word would be appropriate for the button, as the file behaves differently when opened and saved in different browsers, but I couldn't come up with a good idea... |
Hi @tecchan1107 , |
I agree. Sorry, but please correct the code, screenshots, and README. |
What's in this Pull Request?
Added new sample generic-published-version.
This sample creates a button for downloading the currently published version of a document. The sample is supposed to be used in a SharePoint Online document library with minor versions enabled. Button is displayed for every document with a published version, i.e., version at least 1.0. It is linked to the latest published version of the document - for example, if the latest draft of the document is at version 2.6, the button downloads version 2.0.