This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Add the possibility to Update ContentTypes assigned on existing Lists #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tingLists in order to control if CT shall be updated/added on existing lists.
czullu
changed the title
czullu
changed the title
|
Thanks @czullu , I've assigned @erwinvanhunen to this PR |
| @@ -1467,7 +1467,8 @@ private static XElement PrepareField(XElement fieldElement) | |||
| isDirty = false; | |||
| } | |||
|
|
|||
| if (existingList.ContentTypesEnabled) | |||
| //it might make sense to update ContentType on existing list in case we want to add/refresh a ContentType even if users should not choose | |||
| if (existingList.ContentTypesEnabled|| UpdateContentTypeOnExistingLists) | |||
There was a problem hiding this comment.
Maybe the new property shouldn't be called UpdateContentTypeOnExistingLists but something like ForceUpdateListContentType or so. UpdateContentTypeOnExistingLists sounds like I have to to always set it to true because otherwise CTs won't be updated. But this is not the case. They are updated, but only if CTs are enabled on the list.
Or what about UpdateContentTypesEvenOnListsWithDisabledContentTypes?
Naming is hard :-/
There was a problem hiding this comment.
Hi- it could be "ForceUpdateListCTWhenManageCTDisabled" - but maybe a better comment with the parameter would be sufficient as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Added the Option UpdateContentTypeOnExistingLists to ProvisioningTemplateApplyingInformation in order to tell the Methode UpdateList that it can Update ContentTypes on existing Lists.