Fix #1367: Image picker enhancements #1805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
michaelmaillot
requested changes
Aug 10, 2024
There was a problem hiding this comment.
Thanks for the PR @Ateina!
I've added few things to update. Let me know if something's not right from your side 🙂
| } | ||
|
|
||
| .filePickerFolderCardTile { | ||
| max-width: 176px; |
There was a problem hiding this comment.
From what I tested, this property is not mandatory, as it's already calculated from the whole div.
| background-color: "[theme:neutralLighterAlt, default:#{$ms-color-neutralLighterAlt}]"; | ||
| .filePickerFolderCardImage { | ||
| position: relative; | ||
| width: 112px; |
There was a problem hiding this comment.
For width values, I suggest to indicate viewport unit in order to be more responsive:
Suggested change
| width: 112px; | |
| width: 7vw; |
src/controls/filePicker/controls/DocumentLibraryBrowser/DocumentLibraryBrowser.module.scss
Outdated
Show resolved
Hide resolved
…ntLibraryBrowser.module.scss Co-authored-by: Michaël Maillot <[email protected]>
|
@michaelmaillot Thank you for review, I'm working on update for more responsive layout :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
PR contains changes to the FilePicker control to match OOTB Sharepoint File Picker
Before:
PR:
