fix(install.sh): remove url validation (false negatives, redundant) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for getpnpm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If validate_url has stopped working, maybe it's something that needs to be fixed on the server replying to the HEAD request? |
Definately, but who knows when Github will fix the issue? The HEAD request is pretty much pointless anyway |
pnpm/pnpm#7336 Removed url validation since it fails sometimes even though the actual download would succeed. It is also fairly pointless to begin with, only preventing the creation and deletion of a temporary directory.
|
@zkochan I'm not sure how to update the signatures. I think I would need a key. I suppose you would do that, correct? |
zkochan
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm/pnpm#7336
Removed url validation since it fails sometimes even though the actual download would succeed. It is also fairly pointless to begin with, only preventing the creation and deletion of a temporary directory.