Fix possibility to launch multiple VMs on EC2 (178 issue) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 20, 2018 20:42
ID counter was still hardcoded and add_host wasn't work properly
ArseniiPetrovich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've revisioned code during investigation of #178 issue and found that we can replace module-native "count" parameter with the ansible-native "with_sequence" parameter. The downside of that approach in fact that VMs will be launched one by one and not in parallel. However, the other only option for now is to remove ID field, which is much worse, since created VMs will become obscure soon.