Don’t allow calling reveal in release builds
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some structs have a `reveal` method, which deliberately leaks secret information for debug builds. There is no legitimate reason to use them for anything other than debugging, and no uses at all in any of the other codebases I am working on. To ensure that no new uses of this method are added, make this method only available when debug assertions are turned on. This ensures that any attempts to uses this method will break release builds, and thus be quickly discovered.
|
CI failure is due to:
I will fix both. Edit: It seems that we cannot fix both, since at least |
|
I'm glad we take advantage of the massive productivity gains offered by clippy and rustfmt :)
|
|
That's weird. I can't reproduce that locally; also, the "pr" build passed, and only the "push" one failed. For some reason, the latter called and the former didn't. Is it using Rust nightly or beta for some reason?? |
|
Maybe you just need to rebase? The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some structs have a
revealmethod, which deliberately leaks secretinformation for debug builds. There is no legitimate reason to use
them for anything other than debugging, and no uses at all in any of the
other codebases I am working on.
To ensure that no new uses of this method are added, make this method
only available when debug assertions are turned on. This ensures that
any attempts to uses this method will break release builds, and thus be
quickly discovered.