Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/3: Prep for production readiness review #28

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

frankinspace
Copy link
Member

Github Issue: #3

Prepare net2cog for production

Overview of work done

Updated error handling and test cases

Overview of verification done

Updated unit tests and ensured all are passing

Overview of integration done

Ran two test queries against local harmony instance:

Test Case 1

Expectation is a successful conversion to COG

http://localhost:3000/C1234410736-POCLOUD/ogc-api-coverages/1.0.0/collections/sss_smap/coverage/rangeset?format=image%2Ftiff&forceAsync=true&maxResults=1

Result Pass ✅

{
  "username": "greguska",
  "status": "successful",
  "message": "CMR query identified 1929 granules, but the request has been limited to process only the first 1 granules because you requested 1 maxResults.",
  "progress": 100,
  "createdAt": "2024-08-30T21:48:58.101Z",
  "updatedAt": "2024-08-30T21:49:03.666Z",
  "dataExpiration": "2024-09-29T21:48:58.101Z",
  "links": [
    {
      "title": "STAC catalog",
      "href": "http://localhost:3000/stac/88d2a2d4-6857-4567-b3a7-c418b9d197cb/",
      "rel": "stac-catalog-json",
      "type": "application/json"
    },
    {
      "href": "http://localhost:3000/service-results/local-staging-bucket/public/88d2a2d4-6857-4567-b3a7-c418b9d197cb/32/RSS_smap_SSS_L3_8day_running_2015_090_FNL_v04.0_converted_sss_smap.tif",
      "title": "RSS_smap_SSS_L3_8day_running_2015_090_FNL_v04.0_converted_sss_smap.tif",
      "type": "image/tiff; application=geotiff; profile=cloud-optimized",
      "rel": "data",
      "bbox": [
        0.125,
        -89.875,
        -0.125,
        89.875
      ],
      "temporal": {
        "start": "2015-03-27T12:00:00.000Z",
        "end": "2015-04-04T12:00:00.000Z"
      }
    },
    {
      "href": "http://localhost:3000/jobs/88d2a2d4-6857-4567-b3a7-c418b9d197cb?page=1&limit=2000",
      "title": "The current page",
      "type": "application/json",
      "rel": "self"
    }
  ],
  "request": "http://localhost:3000/C1234410736-POCLOUD/ogc-api-coverages/1.0.0/collections/sss_smap/coverage/rangeset?format=image%2Ftiff&forceAsync=true&maxResults=1",
  "numInputGranules": 1,
  "jobID": "88d2a2d4-6857-4567-b3a7-c418b9d197cb"
}

Test Case 2

Expectation is an error indicating net2cog only supports a single variable at this time.

http://localhost:3000/C1234410736-POCLOUD/ogc-api-coverages/1.0.0/collections/all/coverage/rangeset?format=image%2Ftiff&forceAsync=true&maxResults=1

Result Pass ✅

{
  "username": "greguska",
  "status": "failed",
  "message": "WorkItem failed: podaac/net2cog:SIT: net2cog harmony adapter currently only supports processing one variable at a time. Please specify a single variable in your Harmony request.",
  "progress": 99,
  "createdAt": "2024-08-30T21:44:53.350Z",
  "updatedAt": "2024-08-30T21:45:53.251Z",
  "dataExpiration": "2024-09-29T21:44:53.350Z",
  "links": [
    {
      "href": "http://localhost:3000/jobs/11957e1d-a3ed-4cb2-8d35-f5bda964a4c3?page=1&limit=2000",
      "title": "The current page",
      "type": "application/json",
      "rel": "self"
    }
  ],
  "request": "http://localhost:3000/C1234410736-POCLOUD/ogc-api-coverages/1.0.0/collections/all/coverage/rangeset?format=image%2Ftiff&forceAsync=true&maxResults=1",
  "numInputGranules": 1,
  "jobID": "11957e1d-a3ed-4cb2-8d35-f5bda964a4c3",
  "errors": [
    {
      "url": "https://archive.podaac.uat.earthdata.nasa.gov/podaac-uat-cumulus-protected/SMAP_RSS_L3_SSS_SMI_8DAY-RUNNINGMEAN_V4/RSS_smap_SSS_L3_8day_running_2015_090_FNL_v04.0.nc",
      "message": "WorkItem failed: podaac/net2cog:SIT: net2cog harmony adapter currently only supports processing one variable at a time. Please specify a single variable in your Harmony request."
    }
  ]
}

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@frankinspace frankinspace requested a review from a team August 30, 2024 21:50
@frankinspace frankinspace merged commit 8d3685a into develop Aug 30, 2024
7 checks passed
@frankinspace frankinspace deleted the issues/3 branch August 30, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant