fix(HMS-3152): remove pattern matching from location name #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw a follow-up task might be to loosen the check at https://github.com/podengo-project/ipa-hcc/blob/main/src/ipahcc/client/auto_enrollment.py#L90 |
That uses |
|
I think this is the better change to merge. Thank you for the detailed justification in the commit message - but perhaps could you also include a comment in the yaml itself, so that no one will be tempted to put a restriction back onto it? :) |
frasertweedale
approved these changes
Sep 27, 2024
pvoborni
force-pushed
the
remove-dns-regex
branch
from
ce66ad9 to
1dec7c9
Compare
Location name should be a DNS label and could be matched by a regex. Correct one could be "^[a-zA-Z0-9]([a-zA-Z0-9\\-]*[a-zA-Z0-9])*$". PR podengo-project#21 has a discussion about it. But users can defined more values in IPA location in the FreeIPA server than what the RFCs allow. From this PoV, it is more important for idmsvc to pass registration even with slightly invalid DNS label than being valid but failing. Idmsvc doesn't use the value for DNS operations. Signed-off-by: Petr Vobornik <[email protected]>
pvoborni
force-pushed
the
remove-dns-regex
branch
from
1dec7c9 to
5c02a3d
Compare
pvoborni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location name should be a DNS label and could be matched by a regex.
Correct one could be
"^[a-zA-Z0-9]([a-zA-Z0-9\\-]*[a-zA-Z0-9])*$".PR #21 has a discussion about it. But users can defined more values in IPA location in the FreeIPA server than what the RFCs allow.
From this PoV, it is more important for idmsvc to pass registration even with slightly invalid DNS label than being valid but failing. Idmsvc doesn't use the value for DNS operations.