HMS-2692 feat: App secrets with HKDF #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change internal secrets handling to derive domain secrets from a common app secrets with HKDF. `app.domain_reg_key` has been removed. Instead the domain registration token key is derived from `app.secret` using RFC 5869 HKDF extract and expand. In the future, other secrets like JWK encryption key will be derived the same way. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
hms-2692-hkdf-secret
branch
from
affc15e
to
8a885e1
Compare
|
LGTM. Merging. Thanks! |
frasertweedale
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change internal secrets handling to derive domain secrets from a common app secrets with HKDF.
app.domain_reg_keyhas been removed. Instead the domain registration token key is derived fromapp.secretusing RFC 5869 HKDF extract and expand. In the future, other secrets like JWK encryption key will be derived the same way.