fix(HMS-3914): harden dockerfile #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisiedo
force-pushed
the
hms-3914-harden-dockerfile
branch
3 times, most recently
from
ca6f9e7
to
135efc9
Compare
avisiedo
force-pushed
the
hms-3914-harden-dockerfile
branch
from
135efc9
to
88c61b1
Compare
|
I fail to understand what problem this is solving. How can we ever leak credentials when the final container image only contains the binaries, migration scripts, and example config? AFAIK the intermediate build container will never ever leave the build machine. Also we require the |
avisiedo
force-pushed
the
hms-3914-harden-dockerfile
branch
3 times, most recently
from
39c08f9
to
f4bdb53
Compare
Add .docker .podman and .kube to the list of ignored files for the build context of the container image. Signed-off-by: Alejandro Visiedo <[email protected]> Co-authored-by: Christian Heimes <[email protected]>
avisiedo
force-pushed
the
hms-3914-harden-dockerfile
branch
from
f4bdb53
to
929d948
Compare
pvoborni
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
It looks OK, but don't know if it will break something. Going with the same way as in podengo-project/idmsvc-frontend#45 - let's merge this and revert if it breaks something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a policy to ignore by default from .dockerignore file. As .git is not copied, the printing out the last commit is made from the container-build rule. For internal CI/CD we can track the repository related state by the image tag which is the short hash of the repository.
Credits on: insights-rbac contributors