Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT MERGE - WIP Updates in UI #1

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api
56 changes: 50 additions & 6 deletions docs/98-tips.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# Good practices

## Document your components

Document, document, document. Today we are confident about what we are
coding, tomorrow maybe we have forgotten everything about that new,
fancy and awesome component. It is for you, for your team and the
community. A component that is well documented, can be enhanced by
other team mates or the community.

Use TSDoc to add documentation to your components.

See: https://tsdoc.org/

TODO Add examples.

## Break-Down the page and components

This is basically **divide and conquer** principle; smaller things are easier
Expand Down Expand Up @@ -28,7 +42,9 @@ For instance:
import './sample-component.scss';
import React from 'react';

interface SampleComponentProp {
/* SampleComponent component */

interface SampleComponentProps {
name: string;
description: string;
}
Expand All @@ -39,12 +55,10 @@ interface SampleComponentProp {
*
* @param props the props given by the smart component.
*/
const SampleComponent: React.FC<SampleComponentProp> = (props) => {
const SampleComponent = (props: SampleComponentProps) => {
return <span className="sample-component"> {props.children} </span>;
};

SampleComponent.displayName = 'SampleComponent';

export default SampleComponent;
```

Expand All @@ -70,7 +84,7 @@ interface SampleComponentState {
}

/* React component */
const SampleComponent: React.FC<SampleComponentProp> = (props) => {
const SampleComponent = (props: SampleComponentProp) => {
/* Define the states */
const [state, setState] useState<SampleComponentState>({name: props.name, description: props.description});

Expand Down Expand Up @@ -106,7 +120,7 @@ interface MyState {
count: number;
}

const MyComponent: React.FC<MyComponentProps> = (props) => {
const MyComponent = (props: MyComponentProps) => {
const [state, setState] = useState<MyState>({count: 0});
return <span>MyComponent</span>;
};
Expand All @@ -133,6 +147,36 @@ class MyComponent extends React.Component<MyProps, MyState> {
}
```

## Forward properties when no levels or not many levels

The initial approach would be to define for a new component the interface
with the values to be passed as properties; this include values used and `events`
that will receive the parent component. This is the first immediate mechanism
to communicate with the parent component.

```typescript
interface MyComponentProps {
value: string;
onChange: (value: string) => void;
}

const MyComponent = (props: MyComponentProps) => {
const [state, setState] = useState<string>(props.value);
const onChange: (value: string) => {
setState(value);
props.onChange(state);
};
return (
<input onChange={onChange} value={state} />
);
};
```

In the above case, MyComponent receive the value to be displayed into
the `input` component, and when it is changed, the new value is send
to the parent component by calling the onChange callback provided by
the parent component.

## Use context when necessary

The most immediate way to pass information between the components
Expand Down
94 changes: 94 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"babel-jest": "27.0.5",
"babel-plugin-transform-imports": "^2.0.0",
"eslint": "8.18.0",
"eslint-plugin-tsdoc": "^0.2.17",
"eslint-plugin-unused-imports": "^2.0.0",
"identity-obj-proxy": "3.0.0",
"jest": "27.0.5",
Expand Down
Loading