HMS-2151 fix: remember settings on step-back to token page #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user steps back to the token page, settings they provided in the later pages of wizard are forgotten. Avoid this by updating `onVerify` to return early if it detects that the registered state is already `'completed'`. This avoid overwriting the domain in the wizard state with the "pristine" domain data from the `VerifyRegistry` component.
frasertweedale
force-pushed
the
wizard-remember-user-settings
branch
from
8e6034f
to
f1b0737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user steps back to the token page, settings they provided in the later pages of wizard are forgotten.
Avoid this by updating
onVerifyto return early if it detects that the registered state is already'completed'. This avoid overwriting the domain in the wizard state with the "pristine" domain data from theVerifyRegistrycomponent.