Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMS-2906 update title/description microcopy in wizard #21

Merged
merged 1 commit into from
Nov 6, 2023
Merged

HMS-2906 update title/description microcopy in wizard #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Routes/WizardPage/Components/PageReview/PageReview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ const PageReviewIpa = (props: PageReviewProps & { className?: string }) => {
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Identity domain name</DescriptionListTerm>
<DescriptionListTerm>Display name</DescriptionListTerm>
<DescriptionListDescription disabled>{props.domain.title}</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>Identity domain description</DescriptionListTerm>
<DescriptionListTerm>Description</DescriptionListTerm>
<DescriptionListDescription disabled>{props.domain.description}</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
Expand Down
8 changes: 4 additions & 4 deletions src/Routes/WizardPage/Components/PageServiceDetails/PageServiceDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@
}
};

const onChangeTitle = (value: string, event: React.FormEvent<HTMLInputElement>) => {

Check warning on line 54 in src/Routes/WizardPage/Components/PageServiceDetails/PageServiceDetails.tsx

View workflow job for this annotation

GitHub Actions / validate 

'event' is defined but never used
setTitle(value);
if (props.onChangeTitle) {
props.onChangeTitle(value);
}
};

const onChangeDescription = (value: string, event: React.ChangeEvent<HTMLTextAreaElement>) => {

Check warning on line 61 in src/Routes/WizardPage/Components/PageServiceDetails/PageServiceDetails.tsx

View workflow job for this annotation

GitHub Actions / validate 

'event' is defined but never used
setDescription(value);
if (props.onChangeDescription) {
props.onChangeDescription(value);
Expand All @@ -71,13 +71,13 @@
<>
<Form onSubmit={(e) => e.preventDefault()}>
<Title headingLevel={'h2'}>Add your identity domain information</Title>
<FormGroup label="Identity domain name" isRequired fieldId="register-domain-name">
<TextInput id="register-domain-name" value={title} onChange={onChangeTitle} className="pf-u-w-100 pf-u-w-50-on-md pf-u-w-50-on-xl" />
<FormGroup label="Display name" isRequired fieldId="register-title">
<TextInput id="register-title" value={title} onChange={onChangeTitle} className="pf-u-w-100 pf-u-w-50-on-md pf-u-w-50-on-xl" />
</FormGroup>
<FormGroup label="Identity domain description" fieldId="register-domain-description">
<FormGroup label="Description" fieldId="register-description">
<TextArea
contentEditable="true"
id="register-domain-description"
id="register-description"
type="text"
readOnly={false}
className="pf-u-w-100 pf-u-w-50-on-md pf-u-w-50-on-xl"
Expand Down
Loading