HMS-3432 feat: add ouiaid attribute #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
This add the ouiaid attribute at all the considered places so the selection of the components does not depends on the xpath or dom structure of the page. Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-3432-add-ouiaid
branch
from
ba8ae3f
to
5452927
Compare
|
Thanks @avisiedo ! this is awesome. |
mshriver
approved these changes
Jan 25, 2024
|
I think I changed that :) |
|
@mshriver thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the ouiaid attribute at all the considered places so the selection of the components does not depends on the xpath or dom structure of the page.
General naming used:
<Type><Location><Name>Where type so far are used the below:
Button*when the component represent a button or item menu where to do click.Link*for components represented as a link where we can do click.Text*for components that accept text input or represent some label or static text.Location represent the page, modal dialog, or component where it is contained.
Name is the name we assign to select the component.
All together represent the name to be used to select the component.