-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-3165 fix: blank custom deployment #29
Closed
avisiedo
wants to merge
11
commits into
podengo-project:main
from
avisiedo:hms-3165-fix-blank-custom-deployment
Closed
HMS-3165 fix: blank custom deployment #29
avisiedo
wants to merge
11
commits into
podengo-project:main
from
avisiedo:hms-3165-fix-blank-custom-deployment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
avisiedo
force-pushed
the
hms-3165-fix-blank-custom-deployment
branch
from
February 2, 2024 14:34
87086d5
to
211e7a9
Compare
Add annotation with description about the OpenShift template. Signed-off-by: Alejandro Visiedo <[email protected]>
Just add the python dependencies to develop with the repository. Signed-off-by: Alejandro Visiedo <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
Add the set of makefiles to provide the rules to custom deployment in the ephemeral environment. Align this repo with the backend repository. Signed-off-by: Alejandro Visiedo <[email protected]>
Update the alias command to run as it is specified into the platform documentation. Signed-off-by: Alejandro Visiedo <[email protected]>
Add a poc to try to build the frontend container locally, and check if it could be deployed in ephemeral environment. Signed-off-by: Alejandro Visiedo <[email protected]>
Fix wrong copy of files. Signed-off-by: Alejandro Visiedo <[email protected]>
Add bonfire-deploy and update rule to build the container. Signed-off-by: Alejandro Visiedo <[email protected]>
Add .dockerignore with the paths to avoid to copy to the image when the statement 'COPY . .' is executed. Signed-off-by: Alejandro Visiedo <[email protected]>
It was observed some differences between the container generated from the CI/CD platform system and the container generated locally from the repository. This change add several changes to try to be aligned with that changes and generate the same or similar content to what is generated by the platform. Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-3165-fix-blank-custom-deployment
branch
from
February 12, 2024 11:14
211e7a9
to
9d87a7c
Compare
Merged in the graph of #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add ephemeral cluster rules to deploy commits on dev cluster for getting earlier state on dev cluster, fixing the unfinished initial changes for HMS-2678 for the frontend.
Now we could deploy the custom local commits in the ephemeral cluster allowing earlier verification (and not getting the blank screen).