Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HMS-3574): add additional ouiaId #33

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

avisiedo
Copy link
Contributor

@avisiedo avisiedo commented Feb 9, 2024

This change extend the initial ouiaId to cover the compliant components.

This change add a script (not perfect but enough) to do a quick search for the components on the frontend side for the compliant components.

The new name mapping for the type will be the below (copied from the script):

# react-core package           # Prefix to use on ouiaId attribute
opts+=(-e \<Alert)             # Alert
opts+=(-e \<Breadcrumb)        # Breadcrumb
opts+=(-e \<Button)            # Button|Link
opts+=(-e \<Card)              # Card
opts+=(-e \<Checkbox)          # Checkbox
opts+=(-e \<Chip)              # Chip
opts+=(-e \<Dropdown)          # Dropdown
opts+=(-e \<DropdownItem)      # Dropitem
opts+=(-e \<FormSelect)        # Select
opts+=(-e \<Menu)              # Menu
opts+=(-e \<Modal)             # Modal
opts+=(-e \<Navigation)        # Nav
opts+=(-e \<NavExpandable)     # Navexpandable
opts+=(-e \<NavItem)           # Navitem
opts+=(-e \<Pagination)        # Pagination
opts+=(-e \<Radio)             # Radio
opts+=(-e \<Select)            # Select
opts+=(-e \<Switch)            # Switch
opts+=(-e \<TabContent)        # Tabcontent
opts+=(-e \<Tabs)              # Tabs
opts+=(-e \<Text)              # Text
opts+=(-e \<TextInput)         # Textinput
opts+=(-e \<Title)             # Title
opts+=(-e \<Toolbar)           # Toolbar

# react-table package
opts+=(-e \<Table)             # Table
opts+=(-e \<Tr)                # Tr

There are some edge cases that @aadhikar realized about them and motivated the changes on this new PR.

TODO

  • How to tag or select the Wizard buttons Next and Back?
  • How to tag or select the Wizard steps?
  • ... TODO Add more concerns if more arise during the changes.

@avisiedo avisiedo marked this pull request as draft February 9, 2024 14:28
@avisiedo avisiedo force-pushed the hms-3574-ouiaid branch 2 times, most recently from 287bb8a to fec7aef Compare February 12, 2024 13:12
avisiedo and others added 2 commits February 12, 2024 14:56
Add a script to retrieve kind of the location where to add the ouiaId
attribute for compliant components.

See: https://www.patternfly.org/developer-resources/open-ui-automation/#ouia-compliant-patternfly-5-components

Co-authored-by: Akshay Adhikari <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
- [x] Tag the pending components that are complaint with ouiaId.
- [x] Could works wrap some components in a div tag when they are not
      complaint with ouiaId? discarded.
- [x] Are there another way to retrieve the components based on the
      Type? discarded.

It is agreed only the components that are compliant will add the ouiaId
attribute.

Co-authored-by: Akshay Adhikari <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo marked this pull request as ready for review February 12, 2024 14:02
@avisiedo avisiedo self-assigned this Feb 12, 2024
Copy link
Contributor

@aadhikar aadhikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @avisiedo

@avisiedo avisiedo merged commit 3d2daa8 into podengo-project:main Feb 15, 2024
1 check passed
@avisiedo avisiedo deleted the hms-3574-ouiaid branch April 26, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants