Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: update generated api client #47

Merged
merged 1 commit into from
Apr 25, 2024
Merged

api: update generated api client #47

merged 1 commit into from
Apr 25, 2024

Conversation

avisiedo
Copy link
Contributor

Update the api client to be aligned with
podengo-project/idmsvc-api#17

@avisiedo
api: update api
b297698 
Update the api to be aligned with HMS-3429, and re-generate
the javascript client.

Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo self-assigned this Apr 18, 2024
pvoborni
pvoborni approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I tested with:

git submodule update --remote
make generate-api
git diff

And the diff doesn't show any change.

When doing on main branch in shows this .

Please let me know if this was correct process - e.g. for generating similar thing later.

@avisiedo avisiedo merged commit edfbc61 into podengo-project:main Apr 25, 2024
1 check passed
@avisiedo avisiedo deleted the update-api branch April 25, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvoborni pvoborni pvoborni approved these changes

Assignees

@avisiedo avisiedo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avisiedo @pvoborni