feat(HMS-2994): delete domain confirmation #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisiedo
force-pushed
the
hms-2994-delete-confirm
branch
2 times, most recently
from
7fc1f5e
to
5201edf
Compare
pvoborni
reviewed
Apr 25, 2024
src/Components/ConfirmDeleteDomain/ConfirmDeleteDomain.test.tsx
Outdated
Show resolved
Hide resolved
avisiedo
force-pushed
the
hms-2994-delete-confirm
branch
from
5201edf
to
8d9df0b
Compare
avisiedo
force-pushed
the
hms-2994-delete-confirm
branch
from
8d9df0b
to
7ab73e4
Compare
|
I have updated unit tests to be more accurate; the check for the text content of the modal was not working as I expected, so I have removed to avoid confusion; if some immediate way to add the check, happy to know about it. |
pvoborni
approved these changes
Apr 26, 2024
avisiedo
force-pushed
the
hms-2994-delete-confirm
branch
from
7ab73e4
to
c478299
Compare
avisiedo
force-pushed
the
hms-2994-delete-confirm
branch
from
c478299
to
4d656e0
Compare
This change introduce the delete confirmation modal dialog. This dialog will show up when we click on the kebab menu of the list domains view to delete the item, or when we click on the kebab menu from the detail view of the domain to delete the domain that is being displayed. In both cases, the deletion confirmation modal is showed up, and when we press Delete button the item is eventually deleted from the database. Making click on the modal cross icon or cancel link will dismiss the deletion confirmation modal with no effect on the data stored. Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-2994-delete-confirm
branch
from
4d656e0
to
64c5ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduce the delete confirmation modal
dialog.
This dialog will show up when we click on the kebab
menu of the list domains view to delete the item, or
when we click on the kebab menu from the detail view
of the domain to delete the domain that is being
displayed.
In both cases, the deletion confirmation modal is
showed up, and when we press Delete button the
item is eventually deleted from the database.
Making click on the modal cross icon or cancel link
will dismiss the deletion confirmation modal with
no effect on the data stored.