HMS-2584 fix: review UI #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the default content page to be aligned with the current state of the mocks-ups. Signed-off-by: Alejandro Visiedo <[email protected]>
Align the preparation wizard page with what is defined in the mock-ups. Signed-off-by: Alejandro Visiedo <[email protected]>
Move into a third point for the ordered list to collect there the step to install the package if it were not installed. Signed-off-by: Alejandro Visiedo <[email protected]>
This change add an initial component to the wizard, which check verify when the registration happened. This change add new callbacks to the application context to make available the information into the whole application. Signed-off-by: Alejandro Visiedo <[email protected]>
Align the appearance for the pages 2 and 3, add the VerifyRegistry component to the page 2, and update generated api code. Signed-off-by: Alejandro Visiedo <[email protected]>
Align the wizard page review with the mock-ups and link some actions to finish the domain registration process. Signed-off-by: Alejandro Visiedo <[email protected]>
The code to update the data was executed when doing click on Next button for the page 3, however it is expected this call is triggered when the Finish button in the page 4 is clicked. This change fix the above situation as when we do click on the Finish button the event triggered is the onCloseClick. Signed-off-by: Alejandro Visiedo <[email protected]>
Update the margin top to the title of the wizard page, and clean-up some custom styles defined which are not necessary anymore. Signed-off-by: Alejandro Visiedo <[email protected]>
This is about restore the ordered item, but between the paragraphs add a padding. Signed-off-by: Alejandro Visiedo <[email protected]>
As conversations, currently we remove the combobox as we only have one type of service. Signed-off-by: Alejandro Visiedo <[email protected]>
When the step 2 is enabled from the page 1, at the same time the Next button is enabled too, so both are consistent. Signed-off-by: Alejandro Visiedo <[email protected]>
Update the page wizard title to be consistent between the pages. I have to say the page Service Details I had to remove the padding, because it is applied in some place I could not find out the reason. Signed-off-by: Alejandro Visiedo <[email protected]>
Currently by using pattern fly utilities we don't need for the moment any customization for the scss files, so this change clean-up the content of them. Signed-off-by: Alejandro Visiedo <[email protected]>
This fix the situation when sorting by Host domain join on launch column. Signed-off-by: Alejandro Visiedo <[email protected]>
Fix linter violation and clean-up a bit the code. Signed-off-by: Alejandro Visiedo <[email protected]>
For the 'Preparation' wizard page, the informative text content is updated to indicate the below: 'Only Red Hat Identity Management (IdM) is currently supported' Signed-off-by: Alejandro Visiedo <[email protected]>
Update the text content for the item 1 of the registration process to the below: " Register your IdM server with the Red Hat Hybrid Cloud Console by running the following command in a terminal on your IdM server. " Signed-off-by: Alejandro Visiedo <[email protected]>
Multiple fixes in the UI reviewed together with Brian Dielasco. This align UI with all the last changes at October 8th 2023. Signed-off-by: Alejandro Visiedo <[email protected]>
Restoring the text as the demo is recorded. Signed-off-by: Alejandro Visiedo <[email protected]>
|
Merged via #8. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include several fixes on the UI when reviewing the current state.
Please review and merge first #6