DSD Shadow dom #420
Merged
DSD Shadow dom #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsadhu
requested review from
trygve-lie,
leftieFriele,
wkillerud,
tor0405 and
flatoy
trygve-lie
reviewed
Sep 9, 2024
| <script>(()=>{function e(d){HTMLTemplateElement.prototype.hasOwnProperty("shadowRootMode")||d.querySelectorAll("template[shadowrootmode]").forEach(o=>{let | ||
| n=o.getAttribute("shadowrootmode"),s=o.hasAttribute("shadowrootdelegatesfocus"),t=o.parentNode.attachShadow({mode:n,delegatesFocus:s});t.appendChild(o.content),o.remove(),e(t)})}var | ||
| r;(r=document.currentScript)!=null&&r.previousElementSibling&&e(document.currentScript.previousElementSibling);})(); | ||
| </script> |
There was a problem hiding this comment.
Is this needed any more?
There was a problem hiding this comment.
This is the DSD polyfill, I don't think we can let go of this just yet, but I guess hopefully not too long
leftieFriele
approved these changes
Sep 9, 2024
|
🎉 This PR is included in version 5.2.0-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 16, 2024
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt (after feedback) for implementing DSD wrapping for podlets.
A new constructor argument has been added
and asset scopes can be used to place assets inside the Shadow DOM.
For the base use case, thats all you need to do.