fix: sharpen up shadow dom usage assertion #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsadhu
requested review from
trygve-lie,
leftieFriele,
wkillerud,
tor0405 and
flatoy
wkillerud
approved these changes
Sep 23, 2024
|
Would it make sense to mention this in the Readme too? |
leftieFriele
approved these changes
Sep 23, 2024
|
🎉 This PR is included in version 5.2.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Feedback from Dave H that it could be nice to include the invalid name in the message. I also saw that it was probably worth mentioning the use of the wrapWithShadowDOM method in case it is being used directly