-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
359 - One postgres instance for both keycloak and general database #360
359 - One postgres instance for both keycloak and general database #360
Conversation
Coverage report
Test suite run success180 tests passing in 64 suites. Report generated by 🧪jest coverage report action from c717bc9 |
nice and quick - thanks for helping Nizamov! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome upgrade @dimitur2204 🚀
@igoychev I think this setup is only local via docker-compose, so the data exports will be for the testing data only, is that correct? |
I am pretty sure this is the case for the code in this PR. From what I understand from @imilchev his intention was to also do that on production though so that we only have 1 postgres instance to manage, however I think that will require help from him and everyone responsible for production! |
Solves #359
keycloak
database on the currentpostgres
instance.keycloak
to now connect to the newly created databaseMade the changes that @imilchev proposed in an old issue podkrepi-bg/infrastructure#17 in the infrastructure repo.
I don't know if it is still relevant though or if he is talking specifically about the infrastructure as code that is being deployed . In any case if it is needed in the infrastructure repo the solution should be similar
Notes:
There is a
CREATE SCHEMA "public";
line in theinit.sql
file which I am unsure if is relevant in any way, but couldn't test it.This is how the file structure in the pg-db container looks like:
Is that right considering we have 2 databases now @imilchev?