Skip to content

Commit

Permalink
Merge pull request #97 from poetic/fix-open
Browse files Browse the repository at this point in the history
since we're using a wildcard in path, don't wrap open command's in quotes
  • Loading branch information
jakecraige committed Nov 20, 2014
2 parents 2920282 + 39efc38 commit 43a5785
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/utils/open.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ module.exports = function(target, appName) {
opener = 'sudo -u ' + process.env.SUDO_USER + ' ' + opener;
}

return opener + ' "' + target + '"';
return opener + ' ' + target;
}
12 changes: 6 additions & 6 deletions node-tests/unit/tasks/open-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ describe('Tasks - Open', function() {
});

it('ios', function() {
return assertOpenCommand(project, 'ios', 'open "project-root/cordova/platforms/ios/*.xcodeproj"');
return assertOpenCommand(project, 'ios', 'open project-root/cordova/platforms/ios/*.xcodeproj');
});

it('android', function() {
return assertOpenCommand(project, 'android', 'open "project-root/cordova/platforms/android/.project"');
return assertOpenCommand(project, 'android', 'open project-root/cordova/platforms/android/.project');
});
});

Expand All @@ -42,11 +42,11 @@ describe('Tasks - Open', function() {
});

it('ios', function() {
return assertOpenCommand(project, 'ios', 'start "project-root/cordova/platforms/ios/*.xcodeproj"');
return assertOpenCommand(project, 'ios', 'start project-root/cordova/platforms/ios/*.xcodeproj');
});

it('android', function() {
return assertOpenCommand(project, 'android', 'start "project-root/cordova/platforms/android/.project"');
return assertOpenCommand(project, 'android', 'start project-root/cordova/platforms/android/.project');
});
});

Expand All @@ -56,11 +56,11 @@ describe('Tasks - Open', function() {
});

it('ios', function() {
return assertOpenCommand(project, 'ios', 'xdg-open "project-root/cordova/platforms/ios/*.xcodeproj"');
return assertOpenCommand(project, 'ios', 'xdg-open project-root/cordova/platforms/ios/*.xcodeproj');
});

it('android', function() {
return assertOpenCommand(project, 'android', 'xdg-open "project-root/cordova/platforms/android/.project"');
return assertOpenCommand(project, 'android', 'xdg-open project-root/cordova/platforms/android/.project');
});
});
});
Expand Down

0 comments on commit 43a5785

Please sign in to comment.