actually render leashes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
small side note: i noticed the mod version on modrinth is 1.0.5, did you maybe forget to push some code to the repository? if so, i'd advice doing that and then just bumping the version to 1.0.6 |
|
just found out that this breaks outside the development environment for some reason, gotta investigate and fix. |
|
i did some digging, it appears to not even spawn the LeashProxyEntity outside of the dev environment. |
this also fixes leashes not rendering Signed-off-by: rooot <[email protected]>
|
I found the solution! going to really quickly bump the version now |
Signed-off-by: rooot <[email protected]>
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes leashes render (even in multiplayer/on servers)
Yes, this is a one-line fix.
Fixes #7.
Preview:
(i also bumped the version to 1.0.4 since this is a feature addition)