Upgrading biome to 1.8.3 (#241)

Upgrading biome to 1.8.3
pola-rs · Jul 16, 2024 · 9b49663 · 9b49663
1 parent 48bd3b9
commit 9b49663
Show file tree

Hide file tree

Showing 8 changed files with 502 additions and 455 deletions.
diff --git a/__tests__/lazy_functions.test.ts b/__tests__/lazy_functions.test.ts
@@ -153,14 +153,8 @@ describe("lazy functions", () => {
   });
   test.each`
     start  | end  | expected
-    ${"a"} | ${"b"} | ${pl.Series("a", [
-  [1, 2],
-  [2, 3],
-])}
-    ${-1} | ${"a"} | ${pl.Series("literal", [
-  [-1, 0],
-  [-1, 0, 1],
-])}
+    ${"a"} | ${"b"} | ${pl.Series("a", [[1, 2], [2, 3]])}
+    ${-1} | ${"a"} | ${pl.Series("literal", [[-1, 0], [-1, 0, 1]])}
     ${"b"} | ${4} | ${pl.Series("b", [[3], []])}
   `("$# cumMax", ({ start, end, expected }) => {
     const df = pl.DataFrame({ a: [1, 2], b: [3, 4] });

diff --git a/__tests__/series.test.ts b/__tests__/series.test.ts
diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
     "build:ts": " rm -rf bin; tsc -p tsconfig.build.json",
     "cp:bin": "cp ./polars/*.node bin/",
     "format:rs": "cargo fmt",
-    "lint:ts:fix": "biome check --apply-unsafe {polars,__tests__} && biome format --write {polars,__tests__}",
+    "lint:ts:fix": "biome check --write --unsafe {polars,__tests__} && biome format --write {polars,__tests__}",
     "lint:ts": "biome check {polars,__tests__} && biome format {polars,__tests__}",
     "lint": "yarn lint:ts && yarn format:rs",
     "prepublishOnly": "napi prepublish -t npm",
@@ -54,15 +54,15 @@
     "precommit": "yarn lint && yarn test"
   },
   "devDependencies": {
-    "@biomejs/biome": "=1.7.3",
+    "@biomejs/biome": "=1.8.3",
     "@napi-rs/cli": "^2.18.4",
     "@types/chance": "^1.1.6",
     "@types/jest": "^29.5.12",
-    "@types/node": "^20.14.9",
-    "chance": "^1.1.11",
+    "@types/node": "^20.14.10",
+    "chance": "^1.1.12",
     "jest": "^29.7.0",
     "source-map-support": "^0.5.21",
-    "ts-jest": "^29.1.5",
+    "ts-jest": "^29.2.0",
     "ts-node": "^10.9.2",
     "typedoc": "^0.26.3",
     "typescript": "5.5.3"

diff --git a/src/dataframe.rs b/src/dataframe.rs
@@ -188,7 +188,8 @@ pub fn read_json_lines(
     path_or_buffer: Either<String, Buffer>,
     options: ReadJsonOptions,
 ) -> napi::Result<JsDataFrame> {
-    let infer_schema_length = NonZeroUsize::new(options.infer_schema_length.unwrap_or(100) as usize);
+    let infer_schema_length =
+        NonZeroUsize::new(options.infer_schema_length.unwrap_or(100) as usize);
     let batch_size = options
         .batch_size
         .map(|b| NonZeroUsize::try_from(b as usize).unwrap());
@@ -216,7 +217,8 @@ pub fn read_json(
     path_or_buffer: Either<String, Buffer>,
     options: ReadJsonOptions,
 ) -> napi::Result<JsDataFrame> {
-    let infer_schema_length = NonZeroUsize::new(options.infer_schema_length.unwrap_or(100) as usize);
+    let infer_schema_length =
+        NonZeroUsize::new(options.infer_schema_length.unwrap_or(100) as usize);
     let batch_size = options.batch_size.unwrap_or(10000) as usize;
     let batch_size = NonZeroUsize::new(batch_size).unwrap();
     let format: JsonFormat = options
@@ -1113,17 +1115,10 @@ impl JsDataFrame {
         stable: bool,
     ) -> napi::Result<JsDataFrame> {
         let out = if stable {
-            self.df.upsample_stable(
-                by,
-                &index_column,
-                Duration::parse(&every)
-            )
+            self.df
+                .upsample_stable(by, &index_column, Duration::parse(&every))
         } else {
-            self.df.upsample(
-                by,
-                &index_column,
-                Duration::parse(&every)
-            )
+            self.df.upsample(by, &index_column, Duration::parse(&every))
         };
         let out = out.map_err(JsPolarsErr::from)?;
         Ok(out.into())

diff --git a/src/lazy/dataframe.rs b/src/lazy/dataframe.rs
@@ -248,7 +248,7 @@ impl JsLazyFrame {
                 index_column: "".into(),
                 period: Duration::parse(&period),
                 offset: Duration::parse(&offset),
-                closed_window
+                closed_window,
             },
         );
 

diff --git a/src/lazy/dsl.rs b/src/lazy/dsl.rs
@@ -277,7 +277,13 @@ impl JsExpr {
     }
 
     #[napi(catch_unwind)]
-    pub fn value_counts(&self, sort: bool, parallel: bool, name: String, normalize: bool)  -> JsExpr {
+    pub fn value_counts(
+        &self,
+        sort: bool,
+        parallel: bool,
+        name: String,
+        normalize: bool,
+    ) -> JsExpr {
         self.inner
             .clone()
             .value_counts(sort, parallel, name, normalize)
@@ -330,7 +336,10 @@ impl JsExpr {
     }
     #[napi(catch_unwind)]
     pub fn gather(&self, idx: &JsExpr) -> JsExpr {
-        self.clone().inner.gather(idx.inner.clone().cast(DataType::Int64)).into()
+        self.clone()
+            .inner
+            .gather(idx.inner.clone().cast(DataType::Int64))
+            .into()
     }
     #[napi(catch_unwind)]
     pub fn sort_by(&self, by: Vec<&JsExpr>, reverse: Vec<bool>) -> JsExpr {
@@ -462,7 +471,10 @@ impl JsExpr {
     pub fn slice(&self, offset: &JsExpr, length: &JsExpr) -> JsExpr {
         self.inner
             .clone()
-            .slice(offset.inner.clone().cast(DataType::Int64), length.inner.clone().cast(DataType::Int64))
+            .slice(
+                offset.inner.clone().cast(DataType::Int64),
+                length.inner.clone().cast(DataType::Int64),
+            )
             .into()
     }
     #[napi(catch_unwind)]
@@ -955,17 +967,10 @@ impl JsExpr {
             .into()
     }
     #[napi(catch_unwind)]
-    pub fn replace(
-        &self,
-        old: &JsExpr,
-        new: &JsExpr
-    ) -> JsExpr {
+    pub fn replace(&self, old: &JsExpr, new: &JsExpr) -> JsExpr {
         self.inner
             .clone()
-            .replace(
-                old.inner.clone(),
-                new.inner.clone()
-            )
+            .replace(old.inner.clone(), new.inner.clone())
             .into()
     }
     #[napi(catch_unwind)]

diff --git a/src/series.rs b/src/series.rs
@@ -482,22 +482,22 @@ impl JsSeries {
         Ok(JsSeries { series })
     }
     #[napi(catch_unwind)]
-    pub fn sub(&self, other: &JsSeries) -> napi::Result<JsSeries>  {
+    pub fn sub(&self, other: &JsSeries) -> napi::Result<JsSeries> {
         let series = (&self.series - &other.series).map_err(JsPolarsErr::from)?;
         Ok(JsSeries { series })
     }
     #[napi(catch_unwind)]
-    pub fn mul(&self, other: &JsSeries) -> napi::Result<JsSeries>  {
+    pub fn mul(&self, other: &JsSeries) -> napi::Result<JsSeries> {
         let series = (&self.series * &other.series).map_err(JsPolarsErr::from)?;
         Ok(JsSeries { series })
     }
     #[napi(catch_unwind)]
-    pub fn div(&self, other: &JsSeries) -> napi::Result<JsSeries>  {
+    pub fn div(&self, other: &JsSeries) -> napi::Result<JsSeries> {
         let series = (&self.series / &other.series).map_err(JsPolarsErr::from)?;
         Ok(JsSeries { series })
     }
     #[napi(catch_unwind)]
-    pub fn rem(&self, other: &JsSeries) -> napi::Result<JsSeries>  {
+    pub fn rem(&self, other: &JsSeries) -> napi::Result<JsSeries> {
         let series = (&self.series % &other.series).map_err(JsPolarsErr::from)?;
         Ok(JsSeries { series })
     }
@@ -552,7 +552,13 @@ impl JsSeries {
         Ok(unique.into())
     }
     #[napi(catch_unwind)]
-    pub fn value_counts(&self, sort: bool, parallel: bool, name: String, normalize: bool) -> napi::Result<JsDataFrame> {
+    pub fn value_counts(
+        &self,
+        sort: bool,
+        parallel: bool,
+        name: String,
+        normalize: bool,
+    ) -> napi::Result<JsDataFrame> {
         let df = self
             .series
             .value_counts(sort, parallel, name, normalize)