Update pandas queries #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
force-pushed
the
pandas-update
branch
from
85ae04b
to
0bb7759
Compare
|
Generally looks good - I haven't checked through every line carefully, but I have tried running these, and now the timings of "pandas running native queries" and "pandas running Polars queries via Narwhals" are aligned:
Before, for Q2, "pandas native" was 4 times faster than "pandas via Narwhals" - I thought it was a bug in Narwhals, but it turned out was all the manual reordering of operations 😄 I think the small differences that remain are statistical error |
stinodego
force-pushed
the
pandas-update
branch
from
78f0619
to
0fbfd6c
Compare
stinodego
force-pushed
the
pandas-update
branch
from
0fbfd6c
to
c074c2a
Compare
|
Thanks for checking, @MarcoGorelli ! I updated pandas/Dask/Modin with the new queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
This updates the pandas queries to remove any manual optimizations. No more join reordering and no more pre-selecting relevant columns.
This should make it closer to the original SQL query.