clippy/fmt

crates/nano-arrow/src/bitmap/bitmask.rs

@@ -94,6 +94,7 @@ fn load_padded_le_u64(bytes: &[u8]) -> u64 {
     lo | mid | hi
 }
 
+#[derive(Default, Clone)]
 pub struct BitMask<'a> {
     bytes: &'a [u8],
     offset: usize,
@@ -232,16 +233,6 @@ impl<'a> BitMask<'a> {
     }
 }
 
-impl<'a> Default for BitMask<'a> {
-    fn default() -> Self {
-        Self {
-            bytes: &[],
-            offset: 0,
-            len: 0,
-        }
-    }
-}
-
 #[cfg(test)]
 mod test {
     use super::*;

crates/nano-arrow/src/compute/concatenate.rs

@@ -47,7 +47,6 @@ pub fn concatenate(arrays: &[&dyn Array]) -> Result<Box<dyn Array>> {
     Ok(mutable.as_box())
 }
 
-
 /// Concatenate the validities of multiple [Array]s into a single Bitmap.
 pub fn concatenate_validities(arrays: &[&dyn Array]) -> Option<Bitmap> {
     let null_count: usize = arrays.iter().map(|a| a.null_count()).sum();

crates/polars-core/src/datatypes/mod.rs

@@ -62,7 +62,7 @@ pub unsafe trait PolarsDataType: Send + Sync + Sized {
     type ZeroablePhysical<'a>: Zeroable + From<Self::Physical<'a>>;
     type Array: for<'a> StaticArray<
         ValueT<'a> = Self::Physical<'a>,
-        ZeroableValueT<'a> = Self::ZeroablePhysical<'a>
+        ZeroableValueT<'a> = Self::ZeroablePhysical<'a>,
     >;
 
     fn get_dtype() -> DataType

crates/polars-core/src/datatypes/static_array.rs

@@ -68,7 +68,7 @@ pub trait StaticArray:
     fn iter(&self) -> ZipValidity<Self::ValueT<'_>, Self::ValueIterT<'_>, BitmapIter>;
     fn values_iter(&self) -> Self::ValueIterT<'_>;
     fn with_validity_typed(self, validity: Option<Bitmap>) -> Self;
-    
+
     fn from_vec(v: Vec<Self::ValueT<'_>>, dtype: DataType) -> Self {
         v.into_iter().collect_arr_with_dtype(dtype)
     }
@@ -108,7 +108,7 @@ impl<T: NumericNative> StaticArray for PrimitiveArray<T> {
     fn with_validity_typed(self, validity: Option<Bitmap>) -> Self {
         self.with_validity(validity)
     }
-    
+
     fn from_vec(v: Vec<Self::ValueT<'_>>, _dtype: DataType) -> Self {
         PrimitiveArray::from_vec(v)
     }
@@ -145,13 +145,13 @@ impl StaticArray for BooleanArray {
     fn with_validity_typed(self, validity: Option<Bitmap>) -> Self {
         self.with_validity(validity)
     }
-    
+
     fn from_vec(v: Vec<Self::ValueT<'_>>, _dtype: DataType) -> Self {
-        BooleanArray::from_slice(&v)
+        BooleanArray::from_slice(v)
     }
-    
+
     fn from_zeroable_vec(v: Vec<Self::ValueT<'_>>, _dtype: DataType) -> Self {
-        BooleanArray::from_slice(&v)
+        BooleanArray::from_slice(v)
     }
 }
 

crates/polars-ops/src/chunked_array/gather_skip_nulls.rs

@@ -13,7 +13,7 @@ unsafe fn gather_skip_null_idx_pairs_unchecked<'a, T: PolarsDataType>(
     mut index_pairs: Vec<(IdxSize, IdxSize)>,
     len: usize,
 ) -> Vec<T::ZeroablePhysical<'a>> {
-    if index_pairs.len() == 0 {
+    if index_pairs.is_empty() {
         return zeroed_vec(len);
     }