Minor refactor

pola-rs · Oct 23, 2023 · 7be4068 · 7be4068
1 parent ce4e413
commit 7be4068
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/py-polars/src/expr/general.rs b/py-polars/src/expr/general.rs
@@ -341,12 +341,11 @@ impl PyExpr {
 
     fn shift(&self, n: i64, fill_value: Option<Self>) -> Self {
         let expr = self.inner.clone();
-
-        if let Some(v) = fill_value {
-            expr.shift_and_fill(n, v.inner).into()
-        } else {
-            expr.shift(n).into()
-        }
+        let out = match fill_value {
+            Some(v) => expr.shift_and_fill(n, v.inner),
+            None => expr.shift(n)
+        };
+        out.into()
     }
 
     fn fill_null(&self, expr: Self) -> Self {

diff --git a/py-polars/src/lazyframe.rs b/py-polars/src/lazyframe.rs
@@ -836,12 +836,11 @@ impl PyLazyFrame {
 
     fn shift(&self, n: i64, fill_value: Option<PyExpr>) -> Self {
         let lf = self.ldf.clone();
-
-        if let Some(v) = fill_value {
-            lf.shift_and_fill(n, v.inner).into()
-        } else {
-            lf.shift(n).into()
-        }
+        let out = match fill_value {
+            Some(v) => lf.shift_and_fill(n, v.inner),
+            None => lf.shift(n)
+        };
+        out.into()
     }
 
     fn fill_nan(&self, fill_value: PyExpr) -> Self {