Prevent recursive AlreadyEncountered error formatting

pola-rs · Oct 29, 2023 · de6f290 · de6f290
1 parent 6bc3896
commit de6f290
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/crates/polars-plan/src/logical_plan/mod.rs b/crates/polars-plan/src/logical_plan/mod.rs
@@ -79,7 +79,12 @@ impl std::fmt::Display for ErrorState {
         match self {
             ErrorState::NotYetEncountered { err } => write!(f, "NotYetEncountered({err})")?,
             ErrorState::AlreadyEncountered { prev_err_msg } => {
-                write!(f, "AlreadyEncountered({prev_err_msg})")?
+                if prev_err_msg.contains("AlreadyEncountered") {
+                    // Recurively formatting error messages leads to N! memory usage
+                    write!(f, "Multiple AlreadyEncountered")?
+                } else {
+                    write!(f, "AlreadyEncountered({prev_err_msg})")?
+                }
             },
         };