Skip to content

Commit

Permalink
doc: fix incorrect filter syntax (#12143)
Browse files Browse the repository at this point in the history
Co-authored-by: Stijn de Gooijer <[email protected]>
  • Loading branch information
alexander-beedie and stinodego authored Oct 31, 2023
1 parent d4c56a2 commit e592b16
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/development/contributing/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Create a new git branch from the `main` branch in your local repository, and sta
The Rust code is located in the `crates` directory, while the Python codebase is located in the `py-polars` directory.
Both directories contain a `Makefile` with helpful commands. Most notably:

- `make test` to run the test suite (see the [test suite docs](https://github.com/pola-rs/polars/blob/main/py-polars/tests/README.md) for more info)
- `make test` to run the test suite (see the [test suite docs](./test.md) for more info)
- `make pre-commit` to run autoformatting and linting

Note that your work cannot be merged if these checks fail!
Expand All @@ -132,7 +132,7 @@ Please adhere to the following guidelines:
- In the pull request description, [link](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) to the issue you were working on.
- Add any relevant information to the description that you think may help the maintainers review your code.
- Make sure your branch is [rebased](https://docs.github.com/en/get-started/using-git/about-git-rebase) against the latest version of the `main` branch.
- Make sure all [GitHub Actions checks](https://github.com/pola-rs/polars/blob/main/.github/workflows/README.md) pass.
- Make sure all [GitHub Actions checks](./ci.md) pass.

After you have opened your pull request, a maintainer will review it and possibly leave some comments.
Once all issues are resolved, the maintainer will merge your pull request, and your work will be part of the next Polars release!
Expand Down
2 changes: 1 addition & 1 deletion docs/src/python/user-guide/io/cloud-storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
dset = ds.dataset("s3://my-partitioned-folder/", format="parquet")
(
pl.scan_pyarrow_dataset(dset)
.filter("foo" == "a")
.filter(pl.col("foo") == "a")
.select(["foo", "bar"])
.collect()
)
Expand Down

0 comments on commit e592b16

Please sign in to comment.