Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): prepend set_ to set operations on lists #10182

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Jul 30, 2023

credit to @magarick for starting the convo around this on discord

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jul 30, 2023
@magarick
Copy link
Contributor

magarick commented Jul 30, 2023

Any chance we could go with set_{symmetric_}diff and set_intersect? Diff is a common abbreviation consistent with naming elsewhere, intersect is the verb form, and it makes them just a wee bit shorter!

@ritchie46
Copy link
Member

No, I want full names here. In line with their hashbrown parents; https://docs.rs/hashbrown/latest/hashbrown/hash_set/struct.HashSet.html#method.symmetric_difference

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 31, 2023 07:52
@ritchie46 ritchie46 merged commit 9a83e18 into pola-rs:main Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants