Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): added gcs to gcp cloud schema in polars-core::cloud #10206. #10207

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

varunmittal91
Copy link
Contributor

@varunmittal91 varunmittal91 commented Jul 31, 2023

Closes #10206

Added gcs to cloud options parser.

        Ok(match parsed.scheme() {
            "s3" => Self::Aws,
            "az" | "adl" | "abfs" => Self::Azure,
            "gs" | "gcp" | "gcs" => Self::Gcp,
            "file" => Self::File,
            _ => polars_bail!(ComputeError: "unknown url scheme"),
        })

This does not fail on passing gcs as the schema and allows ParquetReader to treat it as a cloud option.

@ritchie46 ritchie46 changed the title Added gcs to gcp cloud schema in polars-core::cloud #10206. feat(rust): added gcs to gcp cloud schema in polars-core::cloud #10206. Aug 1, 2023
@ritchie46 ritchie46 merged commit f3e46da into pola-rs:main Aug 1, 2023
19 checks passed
@ritchie46
Copy link
Member

Thanks!

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched cloud_url schema. is_cloud_url checks expects "gcs" whereas CloudType expects "gs" or "gcp"
3 participants