feat(python): support bytecode translation to map_dict
where the lookup key is an expression
#10265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates
BINARY_SUBSCR
into the generic binary operator translation path so that we can support suggestions where the key is itself an expression.This enables new suggestions for
apply
functions that use lookups, such as......which will now generate the following:
Also: renamed BytecodeParser's
can_rewrite
method tocan_attempt_rewrite
, as we do not know if bytecode containingBINARY_SUBSCR
is rewritable until we check frame variables during expression translation.(For the curious...)