chore(rust): Move dependency version info to workspace level #10295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
alexander-beedie and
universalmind303
as code owners
github-actions
bot
added
internal
stinodego
force-pushed
the
workspace-dep-versions
branch
from
f2ec199
to
9506d78
Compare
stinodego
force-pushed
the
workspace-dep-versions
branch
from
9506d78
to
d7f70f4
Compare
|
@ritchie46 Shall we merge this? I think it should be a nice improvement in our dependency management. |
orlp
requested changes
Aug 9, 2023
orlp
approved these changes
Aug 9, 2023
orlp
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #10279
Changes:
py-polarsCargo.toml (missed these before - see linked PR).I came across some dependencies that are inconsistent across crates (i.e.
regex). I'll see if I can improve this in a separate PR.I left dependencies that exist in a single crate alone for now. Though it's probably nice to have those at workspace level too - I'll leave that for another PR if this one is received well.