Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): Exclude examples from workspace default #10309

Merged
merged 1 commit into from
Aug 5, 2023
Merged

chore(rust): Exclude examples from workspace default #10309

merged 1 commit into from
Aug 5, 2023

Conversation

stinodego
Copy link
Member

This way, we're not building the examples by default every time. You can pass --workspace to cargo commands to include the examples.

This is relevant because the example python_rust_compiled_function causes a linker error when running cargo test in the workspace. See PyO3 docs.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 5, 2023
@stinodego stinodego merged commit 2fc1491 into main Aug 5, 2023
17 checks passed
@stinodego stinodego deleted the examples-not-default branch August 5, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @ritchie46