Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust, python): allow sequential runners in select/with_columns #10322

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

ritchie46
Copy link
Member

Semantics remain the same. Expressions cannot access columns generated in the context. This serves merely as an optimization on small data, when parallelism overhead is too costly.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Aug 6, 2023
@ritchie46
Copy link
Member Author

closes #10316

@avimallu
Copy link
Contributor

avimallu commented Aug 6, 2023

Would this also close #9062?

Copy link
Contributor

@avimallu avimallu Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel there's a small typo, should be:

this will run all expression sequentially instead of in parallel

instead of

this will run all expression sequential instead of in parallel

@ritchie46
Copy link
Member Author

Would this also close #9062?

No, as I described, this doesn't change anything semantically.

@ritchie46 ritchie46 merged commit 51aa46e into main Aug 7, 2023
24 checks passed
@ritchie46 ritchie46 deleted the seq branch August 7, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants