perf(rust): re-use regex capture allocation (#10302) #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
ritchie46
approved these changes
Aug 7, 2023
|
|
||
| // Push nulls if either the string is null or there was no match. We | ||
| // distinguish later between the two by copying arr's validity mask. | ||
| builders.iter_mut().for_each(|arr| arr.push_null()); |
There was a problem hiding this comment.
Yes, makes sense. The copy doesn't add much today, but will be correct once we added a validity to polars' struct type.
| @@ -15,11 +13,6 @@ use super::*; | |||
| #[cfg(feature = "binary_encoding")] | |||
| use crate::chunked_array::binary::BinaryNameSpaceImpl; | |||
|
|
|||
| fn f_regex_extract<'a>(reg: &Regex, input: &'a str, group_index: usize) -> Option<Cow<'a, str>> { | |||
There was a problem hiding this comment.
Yes, nice cleanup. Better to have the implementation separated from the dispatch. 👍
ritchie46
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #10302.