chore(rust): update rustc nightly_2023-08-26 #10467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
ritchie46
commented
Aug 14, 2023
| @@ -134,6 +135,7 @@ pub fn date_ranges( | |||
|
|
|||
| /// Generate a time range. | |||
| #[cfg(feature = "temporal")] | |||
| #[allow(dead_code)] // Remove (invalid hit on nightly 2023-08-14). | |||
There was a problem hiding this comment.
Seems to be a more serious compiler bug.
ritchie46
force-pushed
the
update_rustc
branch
from
5fd2e5e
to
724ccbb
Compare
ritchie46
changed the title
ritchie46
commented
Aug 26, 2023
| @@ -184,6 +184,7 @@ impl Series { | |||
|
|
|||
| /// # Safety | |||
| /// The caller must ensure the length and the data types of `ArrayRef` does not change. | |||
| #[cfg_attr(feature = "nightly", allow(invalid_reference_casting))] | |||
There was a problem hiding this comment.
Will fix this in a separate PR as technically this is UB.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings in LLVM 17